HyukjinKwon commented on a change in pull request #27008: [SPARK-30353][SQL]
Add IsNotNull check in SimplifyBinaryComparison optimization
URL: https://github.com/apache/spark/pull/27008#discussion_r361593116
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BinaryComparisonSimplificationSuite.scala
##########
@@ -122,4 +127,49 @@ class BinaryComparisonSimplificationSuite extends
PlanTest with PredicateHelper
comparePlans(optimized, correctAnswer)
}
+
+ test("Simplify null and nonnull with filter constraints") {
+ Seq('a === 'a, 'a <= 'a, 'a >= 'a, 'a < 'a, 'a > 'a).foreach { condition =>
Review comment:
At the very least you can do `Symbol(...)`. This isn't a nit actually
because we should support Scala 2.13.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
