Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-toree/pull/128#discussion_r127859204
--- Diff:
kernel/src/main/scala/org/apache/toree/boot/layer/ComponentInitialization.scala
---
@@ -82,6 +84,8 @@ trait StandardComponentInitialization extends
ComponentInitialization {
initializePlugins(config, pluginManager)
+ initializeSparkContext(config, kernel)
--- End diff --
Should this be here, or in the kernel's initialization? I think we
eventually want Toree to not require Spark, in which case we would have a
SparkKernel and a regular Kernel. Then it would be the responsibility of the
SparkKernel to detect that the application is in cluster mode and initialize.
Doing this sooner rather than later would avoid more changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
