Github user lresende commented on a diff in the pull request:
https://github.com/apache/incubator-toree/pull/141#discussion_r138677023
--- Diff: etc/pip_install/toree/toreeapp.py ---
@@ -57,6 +59,12 @@ class ToreeInstall(InstallKernelSpec):
spark_home = Unicode(os.getenv(SPARK_HOME, '/usr/local/spark'),
config=True,
--- End diff --
In general, do we actually want to use default values here? I am assuming
we don't really have a standard default place to deploy Spark/Hadoop and maybe
it would be better to use the env variables if they are available, otherwise,
ignore or in case of required ones throw an error?
---
