wilfred-s commented on a change in pull request #125: [YUNIKORN-79] Internal 
metrics are unavailable through REST API
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/125#discussion_r405261907
 
 

 ##########
 File path: pkg/webservice/handlers.go
 ##########
 @@ -279,6 +280,7 @@ func GetContainerHistory(w http.ResponseWriter, r 
*http.Request) {
                if err := json.NewEncoder(w).Encode(result); err != nil {
                        http.Error(w, err.Error(), 
http.StatusInternalServerError)
                }
+               return
 
 Review comment:
   This should be the equivalent of what we have for application history 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to