wilfred-s commented on a change in pull request #95: [YUNIKORN-25] Logging
improvements
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/95#discussion_r406346267
##########
File path: pkg/cache/task.go
##########
@@ -282,8 +290,7 @@ func (task *Task) postTaskAllocated(event *fsm.Event) {
zap.String("podUID", string(task.pod.UID)))
if task.context.apiProvider.GetAPIs().VolumeBinder != nil {
if err := task.context.bindPodVolumes(task.pod); err !=
nil {
- errorMessage = fmt.Sprintf("bind pod volumes
failed, name: %s, uid: %s, %#v",
- task.pod.Name, task.pod.UID, err)
+ errorMessage = fmt.Sprintf("bind pod volumes
failed, name: %s, %#v", task.alias, err)
Review comment:
error does not implement GoStringer, why use `%#v`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
