adamantal commented on pull request #112: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/112#issuecomment-628711745
Thanks for the review @wilfred-s So to sum up, I will put the following constants to SI: ```go // Cluster const DefaultNodeAttributeHostNameKey = "si.io/hostname" const DefaultNodeAttributeRackNameKey = "si.io/rackname" // Application const LabelApp = "app" const LabelApplicationID = "applicationId" const LabelQueueName = "queue" // Resource const Memory = "memory" const CPU = "vcore" // Spark const SparkLabelAppID = "spark-app-selector" const SparkLabelRole = "spark-role" const SparkLabelRoleDriver = "driver" ``` and I will put the following constants into shim: ```go // Cluster const DefaultRackName = "/rack-default" // Application const ApplicationDefaultQueue = "root.sandbox" const DefaultPartition = "default" // Configuration const DefaultConfigMapName = "yunikorn-configs" ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
