akhilpb001 commented on a change in pull request #37:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/37#discussion_r427162042
##########
File path: README.md
##########
@@ -53,7 +53,7 @@ You can set `REGISTRY` and `VERSION` in the commandline to
build docker image wi
```
make image REGISTRY=yunikorn VERSION=latest
```
-this command will build binary with version `latest` and the docker full image
tag is `yunikorn/yunikorn-web:latest`.
+this command will build binary with version `latest` and the docker full image
tag is `yunikorn/yunikorn:web-latest`.
Review comment:
Would n't the image version be `web-latest`?
##########
File path: travis.yaml
##########
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+language: node_js
+node_js:
+ - "12"
+
+git:
+ depth: 1
+
+services:
+ - 'docker'
+
+before_script:
+ - npm install -g @angular/cli
+ - npm install karma
+ - npm install -g protractor
+ - npm install json-server
Review comment:
`json-server` is only used for local development. I don't think we need
it here.
##########
File path: docker-compose.yml
##########
@@ -21,6 +21,6 @@ version: '3'
services:
yunikornwebapp:
build: .
- image: yunikorn/yunikorn-web
+ image: apache/yunikorn
Review comment:
could we use ` yunikorn/yunikorn:web-latest` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]