yangwwei commented on a change in pull request #151:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/151#discussion_r427624459
##########
File path: pkg/scheduler/scheduling_partition.go
##########
@@ -439,36 +440,45 @@ func (psc *partitionSchedulingContext) allocate(alloc
*schedulingAllocation) boo
// Called for both allocations from reserved as well as for direct allocations.
// The unreserve is already handled before we get here so there is no
difference in handling.
// Lock free call this must be called holding the context lock
-func (psc *partitionSchedulingContext) confirmAllocation(appID, nodeID,
allocKey string, confirm bool) error {
+func (psc *partitionSchedulingContext) confirmAllocation(proposal
*commonevents.AllocationProposal, confirm bool) error {
Review comment:
It makes sense. I've moved the notification code to the scheduler, right
after the proposal is confirmed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]