yangwwei commented on a change in pull request #145:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/145#discussion_r427730285
##########
File path: pkg/scheduler/scheduler.go
##########
@@ -407,12 +417,6 @@ func (s *Scheduler) processApplicationUpdateEvent(ev
*schedulerevent.SchedulerAp
acceptedApps = append(acceptedApps,
&si.AcceptedApplication{
ApplicationID: app.ApplicationID,
})
- // app is accepted by scheduler
- err =
app.HandleApplicationEvent(cache.AcceptApplication)
- if err != nil {
- log.Logger().Debug("cache event
handling error returned",
- zap.Error(err))
- }
Review comment:
The Accepted state means the app is accepted by the state (as the
opposite to Rejected). This is a proper place for transiting the app to
`Accepted`. Why do we want to move this to another place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
