wilfred-s commented on a change in pull request #145:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/145#discussion_r428021020
##########
File path: pkg/scheduler/scheduler.go
##########
@@ -407,12 +417,6 @@ func (s *Scheduler) processApplicationUpdateEvent(ev
*schedulerevent.SchedulerAp
acceptedApps = append(acceptedApps,
&si.AcceptedApplication{
ApplicationID: app.ApplicationID,
})
- // app is accepted by scheduler
- err =
app.HandleApplicationEvent(cache.AcceptApplication)
- if err != nil {
- log.Logger().Debug("cache event
handling error returned",
- zap.Error(err))
- }
Review comment:
The Accepted state means that the app is ready for scheduling. When we
add the app it is not ready for scheduling it it only ready for scheduling when
we add an ask to the app.
The application is in a new state until we get that ask added. The
application is rejected by the scheduler if it cannot place the app or it
already exists etc. So the app exists in a state that is un-schedulable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
