kingamarton commented on a change in pull request #156:
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/156#discussion_r428679226



##########
File path: docs/user-guide.md
##########
@@ -109,6 +109,17 @@ Spark uses its own version of the application ID tag 
called *spark-app-id*. This
 When you run Spark on Kubernetes with pod templates, *spark-app-id* is 
considered the applicationId.
 A script to run the spark application and the yaml files are in the [README 
spark](https://github.com/apache/incubator-yunikorn-k8shim/tree/master/deployments/examples#spark)
 section.
 
+### Running a simple Tensorflow job 
+There is a example for Tensorflow job. You must install tf-operator first. You 
can install kubeflow which can auto install tf-operator for you, URL: 
https://www.kubeflow.org/docs/started/getting-started/

Review comment:
       **an** example

##########
File path: docs/user-guide.md
##########
@@ -109,6 +109,17 @@ Spark uses its own version of the application ID tag 
called *spark-app-id*. This
 When you run Spark on Kubernetes with pod templates, *spark-app-id* is 
considered the applicationId.
 A script to run the spark application and the yaml files are in the [README 
spark](https://github.com/apache/incubator-yunikorn-k8shim/tree/master/deployments/examples#spark)
 section.
 
+### Running a simple Tensorflow job 
+There is a example for Tensorflow job. You must install tf-operator first. You 
can install kubeflow which can auto install tf-operator for you, URL: 
https://www.kubeflow.org/docs/started/getting-started/
+
+A simple tfjob example:

Review comment:
       tfjob -> TensorFlow job

##########
File path: docs/user-guide.md
##########
@@ -109,6 +109,17 @@ Spark uses its own version of the application ID tag 
called *spark-app-id*. This
 When you run Spark on Kubernetes with pod templates, *spark-app-id* is 
considered the applicationId.
 A script to run the spark application and the yaml files are in the [README 
spark](https://github.com/apache/incubator-yunikorn-k8shim/tree/master/deployments/examples#spark)
 section.
 
+### Running a simple Tensorflow job 
+There is a example for Tensorflow job. You must install tf-operator first. You 
can install kubeflow which can auto install tf-operator for you, URL: 
https://www.kubeflow.org/docs/started/getting-started/

Review comment:
       Can you please add some description on how tf-operator should be 
installed is somebody doesn't want to install kubeflow for this?

##########
File path: docs/user-guide.md
##########
@@ -109,6 +109,17 @@ Spark uses its own version of the application ID tag 
called *spark-app-id*. This
 When you run Spark on Kubernetes with pod templates, *spark-app-id* is 
considered the applicationId.
 A script to run the spark application and the yaml files are in the [README 
spark](https://github.com/apache/incubator-yunikorn-k8shim/tree/master/deployments/examples#spark)
 section.
 
+### Running a simple Tensorflow job 
+There is a example for Tensorflow job. You must install tf-operator first. You 
can install kubeflow which can auto install tf-operator for you, URL: 
https://www.kubeflow.org/docs/started/getting-started/
+
+A simple tfjob example:
+
+```
+kubectl create -f examples/tfjob/tf-job-mnist.yaml
+```
+
+The file for this example can be found in the [README 
tfjob](https://github.com/apache/incubator-yunikorn-k8shim/tree/master/deployments/examples#tfjob)
 section.

Review comment:
       tfjob -> TensorFlow job




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to