sunilgovind commented on a change in pull request #37:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/37#discussion_r434728298
##########
File path: Makefile
##########
@@ -92,3 +93,9 @@ clean:
rm -rf ./node_modules
rm -rf ./out
rm -rf ./out-tsc
+
+.PHONY: push
+push: image
Review comment:
I am not so sure about this command.
"make push" doesnt seems a good action in make file.
"make image" - creates an image
"make build" - compiles and create binary
"make image --push" - creates an image and push. OR "make push_image" as
well, not so clean. but may be ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]