[GitHub] [incubator-yunikorn-core] yangwwei commented on a change in pull request #173: [YUNIKORN-231] Add ability to update pod condition based on accurate scheduling state

[GitBox]

yangwwei commented on a change in pull request #173:
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/173#discussion_r444571296



##########
File path: pkg/plugins/plugins.go
##########
@@ -50,6 +50,12 @@ func RegisterSchedulerPlugin(plugin interface{}) {
                plugins.reconcilePlugin = t
                registered = true
        }
+       if t, ok := plugin.(ContainerSchedulingStateUpdater); ok {
+               log.Logger().Debug("register scheduler plugin",
+                       zap.String("type", "ContainerSchedulingStateUpdater"))

Review comment:
       But we could not move to `switch` because the logic here allows an 
object that implements multiple plugin interfaces. I added a UT for this too in 
the latest patch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org