wilfred-s commented on pull request #140: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/140#issuecomment-649923800
After discussion off-line the analysis above turned out to be correct and a new change is needed on the core side to support this fix. apache/incubator-yunikorn-core#179 is needed to fix the core side to allow this to properly work. The changes on the shim side are still needed to fix the difference in behaviour around the `AllocationKey`. The fact that `pod.name` can be empty means we need to be really careful using that in any communication between shim and core ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
