wilfred-s commented on a change in pull request #147:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/147#discussion_r448707430
##########
File path: .golangci.yml
##########
@@ -18,9 +18,13 @@
# options for analysis running
run:
issues-exit-code: 1
- skip-dirs-use-default: true
Review comment:
This is independent of what we specify in the `skip-dirs`: it specifies
that the check should not be run against dir like vendor etc. We should leave
it, just to not depend on the defaults from the code.
##########
File path: .golangci.yml
##########
@@ -18,9 +18,13 @@
# options for analysis running
run:
issues-exit-code: 1
- skip-dirs-use-default: true
modules-download-mode: readonly
deadline: 5m
+ skip-dirs:
+ - pkg/client/clientset
+ - pkg/client/informers
+ - pkg/client/listers
+ - pkg/apis/yunikorn.apache.org/v1alpha1/zz_generated.deepcopy.go
Review comment:
I tried this added an extra new line to the file and it did not get
skipped.
Should this not be under `skip-files`
(https://golangci-lint.run/usage/configuration/)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
