wilfred-s commented on pull request #22:
URL: 
https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/22#issuecomment-657342662


   I do have a problem here. 
   
   Application updates are not linked to state changes. The only update of an 
application that triggers a state change is adding the first request to 
allocate a resource, i.e. the first ask will move from a `new` state to an 
`accepted` state.
   All other state changes are based on scheduler actions which are not in 
response to an application update. Adding state changes to the `UpdateResponse` 
is thus not the correct thing to do. First of all: there is no update to 
respond to. It is a self contained change by the scheduler.
   Second point is that there is a large amount of overhead for this message.
   
   We need to roll this message into the one set of updates.
   If we add a status update in the way described we have 3 ways of 
communicating these updates: `OutstandingResourceRequest`, 
`UpdateContainerSchedulingStateRequest` and now `UpdateResponse`.
   
   This is two too many.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to