adamantal opened a new pull request #211:
URL: https://github.com/apache/incubator-yunikorn-core/pull/211
Rationalized a few log items in the core:
- increased log level from DEBUG to INFO when:
- adding a new managed queue
- validating configs (once per partition). More granular logs are kept in
DEBUG level
- registering scheduler plugins
- added a few extra lines in `entrypoint.go` to display what services have
been started with YuniKorn
When the log levels are increased from DEBUG to INFO we will get rid of the
following entries:
1. All the DEBUG level FTM log entries, like this:
```
2020-10-01T14:40:12.912+0200 DEBUG scheduler/scheduler.go:231
enqueued event {"eventType":
"*schedulerevent.SchedulerUpdatePartitionsConfigEvent", "eventError": "json:
unsupported type: chan *commonevents.Result", "currentQueueSize": 0}
```
I think we're fine to remove all these.
2. Outstanding request inspection:
```
2020-10-01T14:40:13.888+0200 DEBUG scheduler/scheduler.go:129 inspect
outstanding requests
2020-10-01T14:42:24.923+0200 DEBUG scheduler/scheduler.go:135
outstanding request {"appID": "batch-sleep-job-1", "allocationKey":
"3574688c-009b-452b-bdf8-2b66d499e02f"}
```
I think both of them can be kept in debug level, because in case of a busy
cluster than can be lots of these logs entries, and by default this log appears
in every second. I added an aggregated variation about the outstanding request
in `inspectOutstandingRequests()` in INFO level. This gives the information
about the size of the pending requests, but does not flood the logs.
3. Queue cleaner
```
2020-10-01T14:41:02.925+0200 DEBUG scheduler/partition_manager.go:62
time consumed for queue cleaner {"duration": "24.489µs"}
```
I think this can be kept in debug level as well, it is not an essential
information.
4. Metrics collection
```
2020-10-01T14:41:12.887+0200 DEBUG metrics/metrics_collector.go:58 Adding
current status to historical partition data
```
This log appears in every minute. I think if we display in `entrypoint.go`
that YuniKorn have started the metrics collection there's no need to display
this in every minute.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
