kingamarton commented on a change in pull request #207:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/207#discussion_r503799418
##########
File path: pkg/webservice/handlers.go
##########
@@ -378,6 +385,20 @@ func updateConfig(w http.ResponseWriter, r *http.Request) {
buildUpdateResponse(true, "", w)
}
+func getConfigurationString(requestBytes []byte, checksum [32]byte) string {
+ newConf := string(requestBytes)
+ checksumString := fmt.Sprintf("%v", checksum)
+ checksumString = strings.ReplaceAll(checksumString, " ", ",")
+ checksumString = "checksum: " + checksumString
Review comment:
That will not work for this case, because in this case we need to have a
string with the checksum bytes delimited by ",". In getClusterConfig() it will
result in a human readable checksum string
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
