FrankinRUC commented on a change in pull request #217: URL: https://github.com/apache/incubator-yunikorn-core/pull/217#discussion_r514078675
########## File path: pkg/scheduler/trace_utils.go ########## @@ -0,0 +1,85 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +package scheduler + +import ( + "fmt" + + "github.com/opentracing/opentracing-go" + + "github.com/apache/incubator-yunikorn-core/pkg/trace" +) + +const ( + LevelKey = "level" + PhaseKey = "phase" + NameKey = "name" + StateKey = "state" + InfoKey = "info" +) + +// startSpanWrapper simplifies span starting process by integrating general tags' setting. +// The level tag is required, nonempty and logs span's scheduling level. (root, partition, queue, ...) +// The phase tag is optional and logs span's calling phase. (reservedAllocate, tryAllocate, allocate, ...) +// The name tag is optional and logs span's related object's identity. (resources' name or ID) Review comment: We can only set the state and info tags after we get the result of the calling, so they are wrapped in the finishActiveSpanWrapper. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
