FrankinRUC edited a comment on pull request #217: URL: https://github.com/apache/incubator-yunikorn-core/pull/217#issuecomment-721601406
Hi @yangwwei , I add some notes for SchedulerTraceContext and the wrapper. I think we cannot avoid it since we don't have AutoCloseable for spans. We have to finish the spans manually like closing useless resources or flushing buffers. CI smoke test failed on TestConfigScheduler. It's kind of weird because I only add some comments. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
