wilfred-s commented on a change in pull request #27:
URL:
https://github.com/apache/incubator-yunikorn-site/pull/27#discussion_r519677640
##########
File path: docs/user_guide/resource_quota_mgmt.md
##########
@@ -22,57 +22,81 @@ specific language governing permissions and limitations
under the License.
-->
-YuniKorn can offer more fine-grained resource quota management comparing to
simply
-using namespace resource quota. Here are some how-to documents about setting up
-resource quota management with YuniKorn queues.
+## Quota configuration and rules
+YuniKorn can offer a finer grained resource quota management setup compared to
the simple
+namespace resource quota provided by Kubernetes.
-## Option 1) Static queues
+Contrary to quotas in Kubernetes YuniKorn does not enforce quotas on
submission but on actively consumed resources.
-### Goal
+Resource quotas in YuniKorn are linked to the queue and its place in the queue
hierarchy.
Review comment:
it's correct, `its place` is the place of the queue in the hierarchy
(possessive form)
`it's placed` is the short for of `it is placed` which does not make sense.
https://www.grammarly.com/blog/its-vs-its/
##########
File path: docs/user_guide/resource_quota_mgmt.md
##########
@@ -22,57 +22,81 @@ specific language governing permissions and limitations
under the License.
-->
-YuniKorn can offer more fine-grained resource quota management comparing to
simply
-using namespace resource quota. Here are some how-to documents about setting up
-resource quota management with YuniKorn queues.
+## Quota configuration and rules
+YuniKorn can offer a finer grained resource quota management setup compared to
the simple
+namespace resource quota provided by Kubernetes.
-## Option 1) Static queues
+Contrary to quotas in Kubernetes YuniKorn does not enforce quotas on
submission but on actively consumed resources.
-### Goal
+Resource quotas in YuniKorn are linked to the queue and its place in the queue
hierarchy.
+The base of the queue structure, the `root` queue, does not allow setting a
quota as it reflects the current size of the cluster.
+Node additions and removals update the `root` queue quota automatically.
-Pre-setup a hierarchy of queues with min/max capacity, users can only submit
-jobs to the leaf queues. This approach fully manages the resource capacity for
-each of the queues, which is suitable to the scenarios that queues do not
change
-too often.
+Beside the `root` queue the quotas can be set, and is enforced, at any point
in the hierarchy.
+Every queue can have a quota set. The quota is enforced recursively throughout
the hierarchy.
+This means that a child queue can never use more resources than the
**configured** quota of the parent queue.
+Setting a quota on a child queue larger than its parent queue's quota would
thus not have any effect and is handled as a configuration error.
-### Configuration
+In the hierarchy there are some further rules that need to be considered.
+If a parent queue has multiple children the sum of the **usage** of all
children combined can never exceed the quota **configured** on the parent.
+However, from a configuration perspective this does not mean that the sum of
the **configured** quotas for all children must be smaller than the parent
quota.
+
+As an example the `root.parent` queue has a quota of 900.
Review comment:
yep added that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
