manirajv06 commented on a change in pull request #223:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r532717866
##########
File path: pkg/scheduler/objects/queue.go
##########
@@ -401,6 +401,28 @@ func (sq *Queue) GetQueueInfos() dao.QueueDAOInfo {
return queueInfo
}
+func (sq *Queue) GetPartitionQueues() dao.PartitionQueueDAOInfo {
+ queueInfo := dao.PartitionQueueDAOInfo{}
+ if len(sq.children) > 0 {
+ for _, child := range sq.GetCopyOfChildren() {
+ queueInfo.Children = append(queueInfo.Children,
child.GetPartitionQueues())
+ }
+ }
+ queueInfo.QueueName = sq.GetQueuePath()
+ queueInfo.Status = sq.stateMachine.Current()
Review comment:
Added readlock to ensure its safety. Also replaced write lock with read
lock in GetQueuePath() which got introduced as part of cache refactoring. Read
lock is good enough in this case. Please verify this as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
