kingamarton commented on a change in pull request #210:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/210#discussion_r534195792
##########
File path: Makefile
##########
@@ -70,6 +70,13 @@ all:
$(MAKE) -C $(dir $(BASE_DIR)) build
.PHONY: lint
+# Run lint against the previous commit for PR and branch build
+# In dev setup look at all changes on top of master
+REV := "HEAD^"
+DETACHED := $(findstring "fatal:", $(shell git symbolic-ref HEAD))
Review comment:
can git symbolic-ref have some fatal messages in case of some other
errors than a detached head? I think it would be better to check the return
status of git symbolic-ref, since it will return 1 if is not a symbolic ref,
and 128 for some other errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
