wilfred-s commented on a change in pull request #225:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/225#discussion_r537187606
##########
File path: Makefile
##########
@@ -52,6 +52,13 @@ all:
$(MAKE) -C $(dir $(BASE_DIR)) build
.PHONY: lint
+# Run lint against the previous commit for PR and branch build
+# In dev setup look at all changes on top of master
+REV := "HEAD^"
+DETACHED := $(findstring "fatal:", $(shell git symbolic-ref HEAD))
Review comment:
Simplified the check, it did not work in all cases either...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
