manirajv06 commented on a change in pull request #229:
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/229#discussion_r540981194



##########
File path: pkg/scheduler/partition.go
##########
@@ -586,6 +586,16 @@ func (pc *PartitionContext) removeNode(nodeID string) 
[]*objects.Allocation {
        return pc.removeNodeInternal(nodeID)
 }
 
+// Update a node

Review comment:
       > Explain what you update on the node and why that triggers the 
partition update etc.
   
   On receiving node update event signal, context#updateNodes calls 
partition#updateNode() to set the correct value for both partition total 
resource and root queue max resource.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to