HuangTing-Yao commented on a change in pull request #213:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/213#discussion_r547705625
##########
File path: pkg/cache/context.go
##########
@@ -552,6 +552,16 @@ func (ctx *Context) RemoveApplication(appID string) error {
}
}
+func (ctx *Context) RemoveApplicationInternal(appID string) error {
Review comment:
OK, done
##########
File path: pkg/cache/application_events.go
##########
@@ -160,3 +162,34 @@ func (fe FailApplicationEvent) GetArgs() []interface{} {
func (fe FailApplicationEvent) GetApplicationID() string {
return fe.applicationID
}
+
+// ------------------------
+// Release application
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
