yangwwei commented on pull request #230: URL: https://github.com/apache/incubator-yunikorn-core/pull/230#issuecomment-755907468
> We can only ever have one state timer in an application there is no need for multiple state timers as an application can only be in one state at a time. The timer is an app instance variable so we always need to call using the app instance. This is a good point. I was saying the same too. We can store a common timer instance in the `StateTimers` struct. And then all the impl details can be hidden in this struct. I was suggesting this way because I think this is 1) easier to read; 2) common impl and can be further re-used by other state machines. However, it is totally up to you and @kingamarton which way to implement this. I should be fine with either approach. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
