yangwwei commented on a change in pull request #230:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/230#discussion_r559088017
##########
File path: pkg/scheduler/partition.go
##########
@@ -1208,3 +1219,11 @@ func (pc *PartitionContext) removeAllocationAsk(appID
string, allocationKey stri
}
}
}
+
+func (pc *PartitionContext) cleanupExpiredApps() {
+ for _, app := range pc.GetAppsByState(objects.Expired.String()) {
+ if app.IsMarkedForRemoval() {
Review comment:
this seems to be a dupe check as the previous line already ensures the
app is in Expired state
can we remove this line and the function `IsMarkedForRemoval()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
