yangwwei commented on pull request #216:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/216#issuecomment-768547171
hi @manirajv06 Looks almost good, but still need to fix the lint issue
```
$ make lint
running golangci-lint
checking against commit sha 2bf276764227
pkg/scheduler/objects/application.go:141:1: receiver name ai should be
consistent with previous receiver name sa for Application (golint)
func (ai *Application) IsCompleted() bool {
^
pkg/scheduler/objects/application.go:145:1: receiver name ai should be
consistent with previous receiver name sa for Application (golint)
func (ai *Application) IsKilled() bool {
^
pkg/scheduler/objects/application.go:149:1: receiver name ai should be
consistent with previous receiver name sa for Application (golint)
func (ai *Application) IsRejected() bool {
^
Makefile:58: recipe for target 'lint' failed
make: *** [lint] Error 1
```
you can run `make lint` locally to ensure there is no more lint issues
before updating the PR. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
