morpheyesh commented on a change in pull request #233:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/233#discussion_r581408260
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -69,24 +124,32 @@ function install_cluster() {
echo "step 2/6: installing helm-v3"
check_cmd "curl"
- curl -L
https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash
- exit_on_error "install helm-v3 failed"
- check_cmd "helm"
+ if ! command -v helm &> /dev/null
+ then
+ install_helm
+ else
+ echo "Helm already installed"
+ fi
Review comment:
Good point. Looks neater now :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
