yangwwei commented on a change in pull request #252:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/252#discussion_r582196360
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -71,6 +71,7 @@ type Application struct {
rmEventHandler handler.EventHandler
rmID string
+ callback func(appID string)
Review comment:
Need a more explicit callback name for this function, easier for people
to understand what this is for
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
