wilfred-s commented on a change in pull request #251:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/251#discussion_r583256581
##########
File path: pkg/scheduler/context.go
##########
@@ -626,27 +656,18 @@ func (cc *ClusterContext) processAsks(request
*si.UpdateRequest) {
continue
}
- // if app info doesn't exist, reject the request
- app := partition.getApplication(siAsk.ApplicationID)
- if app == nil {
- msg := fmt.Sprintf("Failed to find application %s, for
allocation %s", siAsk.ApplicationID, siAsk.AllocationKey)
- log.Logger().Info(msg)
- rejectedAsks = append(rejectedAsks,
Review comment:
This has all been folded into one call. Instead of first checking the
app on the partition and then calling the app directly we call the add on the
partition which calls the add on the app. This brings it inline with the other
checks we do and the siAsk is the loop variable and has not changed. The error
still exists and still gets
[returned](https://github.com/apache/incubator-yunikorn-core/pull/251/files)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
