kingamarton commented on a change in pull request #250:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/250#discussion_r585767240
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -1037,6 +1108,9 @@ func (sa *Application) AddAllocation(info *Allocation) {
func (sa *Application) addAllocationInternal(info *Allocation) {
// placeholder allocations do not progress the state of the app and are
tracked in a separate total
if info.placeholder {
+ if resources.IsZero(sa.allocatedPlaceholder) {
+ sa.initPlaceholderTimer()
+ }
Review comment:
I added some comments to this part to explain why we are starting the
timer at this point
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
