kingamarton commented on a change in pull request #231:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/231#discussion_r589358708
##########
File path: pkg/callback/scheduler_callback.go
##########
@@ -139,6 +150,11 @@ func (callback *AsyncRMCallback)
RecvUpdateResponse(response *si.UpdateResponse)
log.Logger().Error("failed to delete
application", zap.Error(err))
}
} else {
+ if updated.State == events.States().Application.Killed {
+ //TODO: implement the killed event
+ ev :=
cache.NewFailApplicationEvent(updated.ApplicationID)
+ dispatcher.Dispatch(ev)
+ }
Review comment:
As we discussed, we will fail the application, also the placeholders
will be removed. Since the app will be failed, it will be skipped from the next
scheduling cycles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
