wilfred-s commented on pull request #239: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/239#issuecomment-796569410
> Overall the change looks good, but I have one question: why we are not simply using the labels and annotations from the first real pod instead of asking the user to pass them in the taskGroup? There could be a difference between the annotations for different taskgroups. We saw a sidecar injected on placeholders for one task group's placeholders which were blocked by an annotation on the real allocation. It only happened for 1 of the 2 task groups defined for the application. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
