yangwwei commented on pull request #255: URL: https://github.com/apache/incubator-yunikorn-core/pull/255#issuecomment-797840817
> I would not push the `filterApps` flag into the sorting code. StateAware is FIFO with a filter, that is how we have designed and documented it. > Instead I would handle the flag in the `sortApplications()` of the queue. If the flag is false and sort type is StateAware we fall back to FIFO. That keeps all code changes within the queue code. > It also keeps the sorter code cleaner by hiding the optimisation in the queue (looking towards the plugability of the sorter code later on) Updated, could u pls help to review this again? thx ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
