yangwwei commented on a change in pull request #232:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/232#discussion_r595313058
##########
File path: pkg/cache/placeholder.go
##########
@@ -46,6 +46,11 @@ type Placeholder struct {
}
func newPlaceholder(placeholderName string, app *Application, taskGroup
v1alpha1.TaskGroup) *Placeholder {
+ ownerRefs := app.placeholderOwnerReferences
+ controller := false
+ for _, r := range ownerRefs {
+ *r.Controller = controller
+ }
Review comment:
we are setting the controller field to false all the time.
could you pls add some more comments why we are doing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
