wilfred-s commented on a change in pull request #261:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/261#discussion_r599247932
##########
File path: pkg/scheduler/objects/application_test.go
##########
@@ -19,16 +19,49 @@
package objects
import (
+ "math"
"strconv"
"testing"
"time"
+ "github.com/apache/incubator-yunikorn-core/pkg/common/security"
+ "github.com/apache/incubator-yunikorn-core/pkg/rmproxy/rmevent"
+ "github.com/apache/incubator-yunikorn-scheduler-interface/lib/go/si"
"gotest.tools/assert"
"github.com/apache/incubator-yunikorn-core/pkg/common"
"github.com/apache/incubator-yunikorn-core/pkg/common/resources"
)
+// basic app creating with timeout checks
+func TestNewApplication(t *testing.T) {
Review comment:
It really tests the call to NewApplication. I'll add further checks to
show that it is not just for the placeholder timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
