wilfred-s opened a new pull request #248: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/248
Fix the initialisation of the PlaceholderManager structure to init the channel and orphanPods map (renamed). Fix the tests to call NewPlaceholderManager to not init the structure in the test code and thus hiding init issues. The stop channel is never closed and should be reused. We should not create a new channel in the Start but in the New call. Fix up the Stop checks to not use one long 5 second timeout but check every 100ms. This change speeds up the test (down to 0.2s from 8s) and the shutdown of the whole shim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
