wilfred-s commented on a change in pull request #51:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/51#discussion_r602968232
##########
File path: src/app/components/apps-view/apps-view.component.ts
##########
@@ -79,9 +79,7 @@ export class AppsViewComponent implements OnInit {
{ colId: 'resource', colName: 'Resource', colFormatter:
CommonUtil.resourceColumnFormatter },
{ colId: 'queueName', colName: 'Queue Name' },
{ colId: 'priority', colName: 'Priority' },
- { colId: 'partition', colName: 'Partition' },
{ colId: 'nodeId', colName: 'Node ID' },
Review comment:
Can we move node ID further to the start of the table: key, node,
resource and priority.
##########
File path: src/app/components/apps-view/apps-view.component.ts
##########
@@ -79,9 +79,7 @@ export class AppsViewComponent implements OnInit {
{ colId: 'resource', colName: 'Resource', colFormatter:
CommonUtil.resourceColumnFormatter },
{ colId: 'queueName', colName: 'Queue Name' },
Review comment:
Queue name also does not make sense to show under the allocation for an
application.
An application cannot run in multiple queues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
