HuangTing-Yao commented on a change in pull request #245:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/245#discussion_r606808992
##########
File path: pkg/common/events/recorder.go
##########
@@ -31,7 +31,7 @@ import (
"github.com/apache/incubator-yunikorn-k8shim/pkg/conf"
)
-var eventRecorder record.EventRecorder = record.NewFakeRecorder(1024)
+var EventRecorder record.EventRecorder = record.NewFakeRecorder(1024)
Review comment:
got it.
##########
File path: pkg/cache/application_test.go
##########
@@ -177,6 +263,32 @@ func (ms *mockSchedulerAPI) ReloadConfiguration(rmID
string) error {
return nil
}
+type mockRecorder struct {
+ updateFn func()
Review comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
