kingamarton commented on a change in pull request #231: URL: https://github.com/apache/incubator-yunikorn-core/pull/231#discussion_r609536631
########## File path: pkg/webservice/dao/error_info.go ########## @@ -0,0 +1,33 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +package dao + +type YAPIError struct { + StatusCode int `json:"status_code"` + Message string `json:"message"` + Description string `json:"description"` +} + +func NewYAPIError(err error, statusCode int, message string) *YAPIError { Review comment: The `err` parameter is not used. The description should have the value of the `err error` parameter, no? ########## File path: pkg/webservice/routes.go ########## @@ -102,7 +102,15 @@ var webRoutes = routes{ "Scheduler", "PUT", "/ws/v1/config", - updateConfig, + updateClusterConfig, + }, + + // endpoint to update the current conf Review comment: please update the comment here, since this is the endpoint for validating the config, not for updating it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
