wilfred-s commented on a change in pull request #264:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/264#discussion_r610267826
##########
File path: pkg/common/resources/resources.go
##########
@@ -395,12 +395,26 @@ func subNonNegative(left, right *Resource) (*Resource,
string) {
}
return out, message
}
-
-// Check if smaller fitin larger, negative values will be treated as 0
-// A nil resource is treated as an empty resource (zero)
+// Check if smaller fits in larger, negative values will be treated as 0
+// Types not defined in the larger resource are considered 0 values for
Quantity
+// A nil resource is treated as an empty resource (all types are 0)
func FitIn(larger, smaller *Resource) bool {
Review comment:
The skip undefined points to how it was implemented. It is faster than
setting the value to max int64 and doing the comparison. I was trying to
capture the max in the name and had `FitInMaxUndef` as my early choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
