manirajv06 commented on a change in pull request #255:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/255#discussion_r620102449
##########
File path: pkg/client/apifactory.go
##########
@@ -28,15 +28,14 @@ import (
"github.com/apache/incubator-yunikorn-k8shim/pkg/client/informers/externalversions/yunikorn.apache.org/v1alpha1"
"github.com/apache/incubator-yunikorn-k8shim/pkg/common/constants"
- "k8s.io/client-go/informers"
- "k8s.io/client-go/tools/cache"
- "k8s.io/kubernetes/pkg/scheduler/volumebinder"
-
- "github.com/apache/incubator-yunikorn-core/pkg/api"
appclient
"github.com/apache/incubator-yunikorn-k8shim/pkg/client/clientset/versioned"
appinformers
"github.com/apache/incubator-yunikorn-k8shim/pkg/client/informers/externalversions"
"github.com/apache/incubator-yunikorn-k8shim/pkg/conf"
"github.com/apache/incubator-yunikorn-k8shim/pkg/log"
+ apiCommon
"github.com/apache/incubator-yunikorn-scheduler-interface/lib/go/api"
+ "k8s.io/client-go/informers"
+ "k8s.io/client-go/tools/cache"
+ "k8s.io/kubernetes/pkg/scheduler/volumebinder"
Review comment:
Imports ordering happens automatically with editor setup. Have taken
care of de-dupe. Please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
