0yukali0 commented on a change in pull request #266:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/266#discussion_r637331614
##########
File path: pkg/common/utils/gang_utils_test.go
##########
@@ -289,3 +289,45 @@ func TestGetTaskGroupFromAnnotation(t *testing.T) {
assert.Equal(t, taskGroups2[0].MinResource["cpu"],
resource.MustParse("2"))
assert.Equal(t, taskGroups2[0].MinResource["memory"],
resource.MustParse("1Gi"))
}
+
+func TestGetPlaceholderTimeoutParam(t *testing.T) {
Review comment:
Understood.
I will optimize this with table-driven style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
