ycr-oss commented on pull request #276: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/276#issuecomment-864672128
@yangwwei I just realized one potential issue with the suggested approach. If we remove the `preStop` lifecycle hook, then when running the command: ``` kubectl scale deployment yunikorn-scheduler --replicas=0 ``` will disable the scheduler pod but leave the admission controller running, causing all incoming pods to be patched with `schedulerName=yunikorn` but they can't be scheduled because the scheduler pod is down -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
