yuchaoran2011 commented on a change in pull request #279:
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/279#discussion_r657216646



##########
File path: pkg/scheduler/objects/application.go
##########
@@ -841,6 +841,21 @@ func (sa *Application) tryPlaceholderAllocate(nodeIterator 
func() interfaces.Nod
                                        log.Logger().Warn("ask repeat update 
failed unexpectedly",
                                                zap.Error(err))
                                }
+                               // Is real allocation matches with placeholder 
resource?
+                               if ! resources.Equals(alloc.AllocatedResource, 
ph.AllocatedResource) {
+                                       // post scheduling events via the event 
plugin
+                                       if eventCache := 
events.GetEventCache(); eventCache != nil {
+                                               message := fmt.Sprintf("Real 
Pod allocation %s is not matching with placeholder allocation %s in application 
%s", request.AllocationKey, ph.AllocationKey, request.ApplicationID)

Review comment:
       Could you please add in the pod event numerical values of the resources? 
Something like "real resource: %s, placeholder resource: %s"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to