chenya-zhang opened a new pull request #281:
URL: https://github.com/apache/incubator-yunikorn-core/pull/281


   ### What is this PR for?
   
   Defining "totalApplicationsAccepted" and "totalApplicationsRejected" to 
initialize scheduler metrics is redundant in code.
   
   - It can be combined into one "applicationSubmissions" metrics
   - It can use a "prometheus.CounterVec" with different Prometheus labels
   
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [X] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   
   https://issues.apache.org/jira/browse/YUNIKORN-714
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to