yangwwei commented on a change in pull request #285:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/285#discussion_r675306880
##########
File path: pkg/common/si_helper.go
##########
@@ -43,6 +43,10 @@ func createTagsForTask(pod *v1.Pod) map[string]string {
return tags
}
+func CreateTagsForTask(pod *v1.Pod) map[string]string {
+ return createTagsForTask(pod)
+}
+
Review comment:
Looks good, for simplicity, I think we can just rename this function to
`CreateTagsForTask` to expose it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
