chia7712 opened a new pull request #290:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/290


   ### What is this PR for?
   ```go
        n, ok := cache.nodesMap[pod.Spec.NodeName]
        if !ok {
                return fmt.Errorf("node %v is not found", pod.Spec.NodeName)
        }
        if err := n.RemovePod(pod); err != nil {
                return err
        }
   ```
   It can causes DEBUG log("node  is not found") if node name is an empty 
string. For example: the pod status is updated (according to outstanding 
requests) before it is assumed to be run on a node.
   
   
   ### What type of PR is it?
   * [x] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-770
   
   ### How should this be tested?
   `TestRemovePodWithoutNodeName`
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to